Skip to content

Guard a query invocation out of perf reasons#138746

Closed
oli-obk wants to merge 1 commit intorust-lang:masterfrom
oli-obk:push-tzszzuonznky
Closed

Guard a query invocation out of perf reasons#138746
oli-obk wants to merge 1 commit intorust-lang:masterfrom
oli-obk:push-tzszzuonznky

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 20, 2025 •
edited
Loading

Should fix the perf regression from #138674

@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 20, 2025
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 20, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 20, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 20, 2025
@bors
Auto merge of rust-lang#138746 - oli-obk:push-tzszzuonznky, r=<try>
a41be90 
Guard a query invocation out of perf reasons

Should fix the perf regression from rust-lang#138674
@bors
Copy link
Collaborator

bors commented Mar 20, 2025

⌛ Trying commit 2a31e68 with merge a41be90...

@lqd
Copy link
Member

lqd commented Mar 20, 2025

r=me with green perf

@bors
Copy link
Collaborator

bors commented Mar 20, 2025

☀️ Try build successful - checks-actions
Build commit: a41be90 (a41be901a653bf995bd4d95c6f96dcf62c5f8da6)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Mar 20, 2025

Finished benchmarking commit (a41be90): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%, secondary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.4% [1.7%, 3.1%] 2
Improvements ✅
(primary)		 -2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.84s -> 774.046s (0.03%)
Artifact size: 365.50 MiB -> 365.50 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 20, 2025
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 20, 2025

Nope that wasn't it

@oli-obk oli-obk closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nnethercote nnethercote

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oli-obk @rustbot @rust-timer @bors @lqd @nnethercote